xushiyan commented on code in PR #13902: URL: https://github.com/apache/hudi/pull/13902#discussion_r2361484066
########## docker/setup_demo.sh: ########## @@ -20,8 +20,8 @@ SCRIPT_PATH=$(cd `dirname $0`; pwd) HUDI_DEMO_ENV=$1 WS_ROOT=`dirname $SCRIPT_PATH` COMPOSE_FILE_NAME="docker-compose_hadoop284_hive233_spark353_amd64.yml" -if [ "$HUDI_DEMO_ENV" = "--mac-aarch64" ]; then - COMPOSE_FILE_NAME="docker-compose_hadoop284_hive233_spark353_arm64.yml" +if [ "$(uname -m)" = "arm64" ]; then Review Comment: @deepakpanda93 in follow up pr, clean up this `HUDI_DEMO_ENV` as you made it unused. Also update any docs (search in branch asf-site) that shows how to use this script accordingly. ########## docker/stop_demo.sh: ########## @@ -21,8 +21,8 @@ HUDI_DEMO_ENV=$1 # set up root directory WS_ROOT=`dirname $SCRIPT_PATH` COMPOSE_FILE_NAME="docker-compose_hadoop284_hive233_spark353_amd64.yml" -if [ "$HUDI_DEMO_ENV" = "--mac-aarch64" ]; then Review Comment: same as the setup demo script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
