yihua commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2362057996
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieBloomFilterWriteSupport.java:
##########
@@ -55,15 +55,19 @@ public HoodieBloomFilterWriteSupport(BloomFilter
bloomFilter) {
public void addKey(T recordKey) {
bloomFilter.add(getUTF8Bytes(recordKey));
- if (minRecordKey == null || minRecordKey.compareTo(recordKey) > 0) {
+ if (minRecordKey == null || compareRecordKey(minRecordKey, recordKey) > 0)
{
Review Comment:
Got it. That makes sense.
##########
hudi-spark-datasource/README.md:
##########
@@ -23,12 +23,16 @@ This repo contains the code that integrate Hudi with Spark.
The repo is split in
`hudi-spark3.3.x`
`hudi-spark3.4.x`
`hudi-spark3.5.x`
+`hudi-spark4.0.x`
+`hudi-spark3-common`
`hudi-spark-common`
* hudi-spark is the module that contains the code that spark3 version would
share.
* hudi-spark3.3.x is the module that contains the code that compatible with
spark3.3.x versions.
* hudi-spark3.4.x is the module that contains the code that compatible with
spark 3.4.x versions.
* hudi-spark3.5.x is the module that contains the code that compatible with
spark 3.5.x versions.
+* hudi-spark4.0.x is the module that contains the code that compatible with
spark 4.0.x versions.
+* hudi-spark3-common is the module that contains the code that would be reused
between spark3.x versions.
* hudi-spark-common is the module that contains the code that would be reused
between spark3.x versions.
Review Comment:
Change this line
##########
hudi-spark-datasource/hudi-spark-common/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister:
##########
@@ -16,5 +16,5 @@
# limitations under the License.
-org.apache.hudi.DefaultSource
+org.apache.hudi.SparkBaseDefaultSource
Review Comment:
```suggestion
org.apache.hudi.BaseDefaultSource
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
