danny0405 commented on code in PR #13943:
URL: https://github.com/apache/hudi/pull/13943#discussion_r2365895137


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedFileFormat.scala:
##########
@@ -378,13 +381,28 @@ class HoodieFileGroupReaderBasedFileFormat(tablePath: 
String,
       //then we will read (dataSchema + a + c) and append b. So the final 
schema will be (data schema + a + c +b)
       //but expected output is (data schema + a + b + c)
       val pfileUtils = sparkAdapter.getSparkPartitionedFileUtils
-      val partitionValues = getFixedPartitionValues(file.partitionValues, 
partitionSchema, fixedPartitionIndexes)
+      val typedPartitionValues = 
ensurePartitionValuesTyped(file.partitionValues, partitionSchema)

Review Comment:
   While I see in `#doParsePartitionColumnValues` some branches just parse the 
partiton values as strings and one branch parse it as specific data type. The 
string values seem not related with the hive style partitioning though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to