yihua commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2359321397
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkMetadataWriterUtils.java:
##########
@@ -178,12 +185,13 @@ public static ExpressionIndexComputationMetadata
getExpressionIndexRecordsUsingC
HoodieColumnRangeMetadata<Comparable> rangeMetadata =
HoodieColumnRangeMetadata.create(
relativeFilePath,
columnToIndex,
- minValue,
- maxValue,
+ (Comparable)
valueMetadata.standardizeJavaTypeAndPromote(minValue),
+ (Comparable)
valueMetadata.standardizeJavaTypeAndPromote(maxValue),
nullCount,
valueCount,
totalFileSize,
- totalUncompressedSize
+ totalUncompressedSize,
+ valueMetadata
Review Comment:
We decided to punt this and refactor the code once the new Type System is
ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
