the-other-tim-brown opened a new pull request, #13962:
URL: https://github.com/apache/hudi/pull/13962
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
The HFile read performance is critical for good query performance for Hudi
users. As part of auditing that code path, I discovered that we do a few steps
per record that can be done once per file read. The writer path had similar
issues.
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
In both the reader and writer path, this PR aims to only check if the key
field exists once for a given file or batch of records.
Only the reader path, the DatumReader is also reused to avoid recreating
this object per record.
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
In local testing against a 4.5Mb col stats HFile, I saw a 20% reduction in
time taken to deserialize the file.
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
Low
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
