danny0405 commented on code in PR #13964:
URL: https://github.com/apache/hudi/pull/13964#discussion_r2370868769
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/buffer/FileGroupRecordBuffer.java:
##########
@@ -238,6 +241,10 @@ protected Option<Pair<Function<T, T>, Schema>>
composeEvolvedSchemaTransformer(
protected boolean hasNextBaseRecord(T baseRecord, BufferedRecord<T>
logRecordInfo) throws IOException {
if (logRecordInfo != null) {
+ if (inflateRecordsBeforeMerging && !logRecordInfo.isDelete()) {
+ T logRecord =
readerContext.getRecordContext().inflateRecord(logRecordInfo.getRecord(),
incomingRecordsSchema);
Review Comment:
not sure why we need this, in `StreamingFileGroupRecordBufferLoader`, we
already execute `#recordContext.extractDataFromRecord` per record to decode the
engine row, that should where the schema been injected in? And within the
`HoodieAvroIndexedRecord`, the decode of the record is already lazy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
