yihua commented on code in PR #13968:
URL: https://github.com/apache/hudi/pull/13968#discussion_r2370795466
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/StorageBasedLockConfig.java:
##########
@@ -42,11 +42,12 @@ public class StorageBasedLockConfig extends HoodieConfig {
+ "The lock provider will attempt to renew its lock until it
successfully extends the lock lease period "
+ "or the validity timeout is reached.");
- public static final ConfigProperty<Long> HEARTBEAT_POLL_SECONDS =
ConfigProperty
- .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "heartbeat.poll.secs")
+ public static final ConfigProperty<Long> RENEW_INTERVAL_SECS = ConfigProperty
+ .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "renew.interval.secs")
.defaultValue(30L)
.markAdvanced()
.sinceVersion(SINCE_VERSION_1_0_2)
+ .withAlternatives(STORAGE_BASED_LOCK_PROPERTY_PREFIX +
"heartbeat.poll.secs")
Review Comment:
Have you checked that there is no invocation of `RENEW_INTERVAL_SECS.key()`
to get the config value? If so, the alternative config key is not going to
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
