danny0405 commented on code in PR #13964:
URL: https://github.com/apache/hudi/pull/13964#discussion_r2373813246
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecords.java:
##########
@@ -48,6 +48,24 @@ public static <T> BufferedRecord<T>
fromHoodieRecord(HoodieRecord record, Schema
return new BufferedRecord<>(recordKey,
recordContext.convertOrderingValueToEngineType(orderingValue), data, schemaId,
inferOperation(isDelete, record.getOperation()));
}
+ public static <T> BufferedRecord<T>
fromHoodieRecordWithDeflatedRecord(HoodieRecord record, Schema schema,
RecordContext<T> recordContext, Properties props,
+
String[] orderingFields, DeleteContext deleteContext) {
+ HoodieOperation hoodieOperation = record.getIgnoreIndexUpdate() ?
HoodieOperation.UPDATE_BEFORE : record.getOperation();
+ boolean isDelete = record.isDelete(deleteContext, props);
+ return fromHoodieRecordWithDeflatedRecord(record, schema, recordContext,
props, orderingFields, isDelete, hoodieOperation);
+ }
+
+ public static <T> BufferedRecord<T>
fromHoodieRecordWithDeflatedRecord(HoodieRecord record, Schema schema,
RecordContext<T> recordContext,
Review Comment:
I didn't see why we need this, can we get rid of it if
`#extractDeflatedDataFromRecord` is no longer needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
