linliu-code commented on code in PR #13953:
URL: https://github.com/apache/hudi/pull/13953#discussion_r2379924779
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -163,6 +163,15 @@ public HoodieStreamer(Config cfg, JavaSparkContext jssc,
FileSystem fs, Configur
cfg.recordMergeMode = mergingConfigs.getLeft();
cfg.payloadClassName = mergingConfigs.getMiddle();
cfg.recordMergeStrategyId = mergingConfigs.getRight();
+ if (null != cfg.recordMergeMode &&
!StringUtils.isNullOrEmpty(cfg.recordMergeMode.name())) {
+ this.properties.put(HoodieTableConfig.RECORD_MERGE_MODE.key(),
cfg.recordMergeMode.name());
+ }
+ if (!StringUtils.isNullOrEmpty(cfg.payloadClassName)) {
+ this.properties.put(HoodieTableConfig.PAYLOAD_CLASS_NAME.key(),
cfg.payloadClassName);
+ }
+ if (!StringUtils.isNullOrEmpty(cfg.recordMergeStrategyId)) {
+ this.properties.put(HoodieTableConfig.RECORD_MERGE_STRATEGY_ID.key(),
cfg.recordMergeStrategyId);
Review Comment:
> Does Spark Datasource and SQL writer fail in the validation in the same
place is the merge (write or table) configs are changed?
Yes. This is our goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
