linliu-code commented on code in PR #13977:
URL: https://github.com/apache/hudi/pull/13977#discussion_r2380417976


##########
hudi-io/src/test/java/org/apache/hudi/io/hfile/TestHFileWriter.java:
##########
@@ -74,15 +75,17 @@ void testOverflow() throws Exception {
 
   @Test
   void testSameKeyLocation() throws IOException {
-    // 50 bytes for data part limit.
-    HFileContext context = new HFileContext.Builder().blockSize(100).build();
+    // 165 bytes for data part limit.
+    HFileContext context = new HFileContext.Builder().blockSize(165).build();
     String testFile = TEST_FILE;
     try (DataOutputStream outputStream =
              new DataOutputStream(Files.newOutputStream(Paths.get(testFile)));
         HFileWriter writer = new HFileWriterImpl(context, outputStream)) {
-      for (int i = 0; i < 10; i++) {
+      // All entries for key00 are stored in the first block.
+      for (int i = 0; i < 100; i++) {
         writer.append("key00", String.format("value%02d", i).getBytes());
       }
+      // Otherwise, 5 records in each other blocks.

Review Comment:
   yes. Added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to