vinothchandar commented on a change in pull request #2332:
URL: https://github.com/apache/hudi/pull/2332#discussion_r545467367
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/HoodieWriteClient.java
##########
@@ -701,8 +704,6 @@ protected void completeCompaction(HoodieCommitMetadata
metadata, JavaRDD<WriteSt
finalizeWrite(table, compactionCommitTime, writeStats);
LOG.info("Committing Compaction " + compactionCommitTime + ". Finished
with result " + metadata);
- table.metadataWriter(jsc).update(metadata, compactionCommitTime);
-
Review comment:
yes correct. even for compaction, once the compaction commits, it will
trigger a sync. I think we should ensure the sync only happens for commit
operations (i.e only one allowed at the moment). I ll double check this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
