cshuo commented on code in PR #13964:
URL: https://github.com/apache/hudi/pull/13964#discussion_r2386542121
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java:
##########
@@ -244,6 +244,10 @@ public Comparable<?> getOrderingValue(Schema recordSchema,
Properties props, Str
return orderingValue;
}
+ public Comparable<?> getCachedOrderingValue() {
Review Comment:
The method seems not necessary.
IIUC, The intention is trying not to inflate SerializableIndexedRecord when
get ordering value by best effort. Currently, `getOrderingValue` will first
fetch ordering value from internal cache, and do extracting logic only when
cache value is null, so it will be ok to call `getOrderingValue` directly.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/model/HoodieFlinkRecord.java:
##########
@@ -103,7 +103,7 @@ protected Comparable<?> doGetOrderingValue(Schema
recordSchema, Properties props
if (recordSchema.getField(field) == null) {
return OrderingValues.getDefault();
}
- return (Comparable<?>) getColumnValue(recordSchema, field, props);
+ return (Comparable<?>) getColumnValueAsJava(recordSchema, field,
props, false);
Review Comment:
We currently return ordering value as engine type for `getOrderingValue`, so
we should not make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
