alexr17 commented on code in PR #14022:
URL: https://github.com/apache/hudi/pull/14022#discussion_r2393004861
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/models/LockProviderHeartbeatManager.java:
##########
@@ -228,7 +228,7 @@ private void heartbeatTaskRunner(Thread threadToMonitor) {
private boolean executeHeartbeat(Thread threadToMonitor) {
// Check if monitored thread is dead
if (!threadToMonitor.isAlive()) {
- logger.warn("Owner {}: Monitored thread is no longer alive.", ownerId);
+ logger.info("Owner {}: Monitored thread is no longer alive.", ownerId);
Review Comment:
this i believe should be a warn situation. definitely a rare case, but
something we want to notice in the logs vs info or error. we exit gracefully,
but it's indicative of a larger problem if the writer thread exits without
ending the transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
