linliu-code commented on code in PR #14041:
URL: https://github.com/apache/hudi/pull/14041#discussion_r2400104017
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestPayloadDeprecationFlow.scala:
##########
@@ -260,17 +264,20 @@ class TestPayloadDeprecationFlow extends
SparkClientFunctionalTestHarness {
}
// 9-10. Perform downgrade and validation
- performDowngradeAndValidate(metaClient, basePath,
expectedDowngradeConfigs, expectedData, columns, serviceOpts)
+ performDowngradeAndValidate(metaClient, basePath,
expectedDowngradeConfigs, expectedData, columns, serviceOpts,
startVersion.toInt)
}
@ParameterizedTest
- @MethodSource(Array("providePayloadClassTestCases"))
- def testMergerBuiltinPayloadFromTableCreationPath(tableType: String,
+ @MethodSource(Array("providePayloadClassTestCasesForTableCreation"))
+def testMergerBuiltinPayloadFromTableCreationPath(tableVersion: String,
Review Comment:
indent.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestPayloadDeprecationFlow.scala:
##########
@@ -46,12 +46,15 @@ class TestPayloadDeprecationFlow extends
SparkClientFunctionalTestHarness {
*/
@ParameterizedTest
@MethodSource(Array("providePayloadClassTestCases"))
- def testMergerBuiltinPayloadUpgradeDowngradePath(tableType: String,
+ def testMergerBuiltinPayloadUpgradeDowngradePath(startVersion: String,
+ tableType: String,
Review Comment:
Indention is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
