jonvex commented on code in PR #14085:
URL: https://github.com/apache/hudi/pull/14085#discussion_r2433465694
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -169,12 +169,37 @@ protected <T> ClosableIterator<HoodieRecord<T>>
lookupRecords(List<String> sorte
try (final HoodieAvroHFileReaderImplBase reader =
(HoodieAvroHFileReaderImplBase) HoodieIOFactory
.getIOFactory(inlineStorage)
.getReaderFactory(HoodieRecordType.AVRO)
- .getFileReader(ConfigUtils.DEFAULT_HUDI_CONFIG_FOR_READER, inlinePath,
HoodieFileFormat.HFILE, Option.of(getSchemaFromHeader()))) {
+ .getFileReader(ConfigUtils.DEFAULT_HUDI_CONFIG_FOR_READER,
blockContentLoc.getLogFile().getPathInfo(), HoodieFileFormat.HFILE,
Option.of(getSchemaFromHeader()))) {
Review Comment:
we are dropping the inline stuff here. Are we sure this isn't going to be an
issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
