nsivabalan commented on code in PR #14069:
URL: https://github.com/apache/hudi/pull/14069#discussion_r2437060282
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -823,9 +825,15 @@ private int estimateFileGroupCount(long recordCount) {
minFileGroupCount = dataWriteConfig.getRecordIndexMinFileGroupCount();
maxFileGroupCount = dataWriteConfig.getRecordIndexMaxFileGroupCount();
}
+ Supplier<Long> recordCountSupplier = () -> {
+ records.persist("MEMORY_AND_DISK_SER");
+ long count = records.count();
+ LOG.info("Initializing record index with {} mappings", count);
+ return count;
Review Comment:
can we file a follow up to further optimize this by sampling instead of
getting the exact count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
