danny0405 commented on code in PR #13964:
URL: https://github.com/apache/hudi/pull/13964#discussion_r2386552787


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java:
##########
@@ -244,6 +244,10 @@ public Comparable<?> getOrderingValue(Schema recordSchema, 
Properties props, Str
     return orderingValue;
   }
 
+  public Comparable<?> getCachedOrderingValue() {

Review Comment:
   +1, let's not add API that is ambiguous, and always returns a non-null 
ordering value if the ordering field is defined there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to