the-other-tim-brown commented on code in PR #13975:
URL: https://github.com/apache/hudi/pull/13975#discussion_r2373871743
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java:
##########
@@ -407,16 +407,16 @@ public void write(HoodieRecord<T> oldRecord) {
}
}
- protected void writeToFile(HoodieKey key, HoodieRecord<T> record, Schema
schema, Properties prop, boolean shouldPreserveRecordMetadata) throws
IOException {
+ protected void writeToFile(HoodieKey key, HoodieRecord<T> record, Schema
schema, Properties props, boolean shouldPreserveRecordMetadata) throws
IOException {
if (shouldPreserveRecordMetadata) {
// NOTE: `FILENAME_METADATA_FIELD` has to be rewritten to correctly
point to the
// file holding this record even in cases when overall metadata is
preserved
HoodieRecord populatedRecord = record.updateMetaField(schema,
HoodieRecord.FILENAME_META_FIELD_ORD, newFilePath.getName());
- fileWriter.write(key.getRecordKey(), populatedRecord,
writeSchemaWithMetaFields);
+ fileWriter.write(key.getRecordKey(), populatedRecord,
writeSchemaWithMetaFields, props);
Review Comment:
The props are only used when converting the payload based hoodie records. I
think at this point though, the expectation is everything is a
HoodieAvroIndexedRecord. I wanted to let CI run to confirm this was the case. I
thought it was odd we had an unused variable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
