vamshikrishnakyatham commented on code in PR #14008:
URL: https://github.com/apache/hudi/pull/14008#discussion_r2389421128
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1667,7 +1667,7 @@ private void validateRollback(String
commitToRollbackInstantTime) {
// Hence, this case implies a rollback of completed commit which should
actually be handled using restore.
if (compactionInstant.getAction().equals(COMMIT_ACTION)) {
final String compactionInstantTime = compactionInstant.requestedTime();
- if (commitToRollbackInstantTime.length() ==
compactionInstantTime.length() &&
LESSER_THAN_OR_EQUALS.test(commitToRollbackInstantTime, compactionInstantTime))
{
+ if (wasCommitInCompactionScope(commitToRollbackInstantTime,
compactionInstant, metadataMetaClient.getActiveTimeline())) {
Review Comment:
The previous change in this PR handled the pending instants which needs no
validation to rollback which was missed. Added it back @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
