danny0405 commented on code in PR #13987:
URL: https://github.com/apache/hudi/pull/13987#discussion_r2387473998


##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestUpdateProcessor.java:
##########
@@ -145,7 +146,7 @@ void testHandleInsertWithPayload(boolean shouldIgnore) {
     when(recordContext.seal(any())).thenAnswer(invocationOnMock -> 
invocationOnMock.getArgument(0));
     BufferedRecord<IndexedRecord> previous = null;
     BufferedRecord<IndexedRecord> merged = getRecord("value2", null);
-    BufferedRecord<IndexedRecord> expected = getRecord("value2", 
HoodieOperation.INSERT);
+    BufferedRecord<IndexedRecord> expected = 
getRecordWithSerializableIndexedRecord("value2", HoodieOperation.INSERT);

Review Comment:
   we can also chenge the `getRecord` to always create 
`SerializableIndexRecord` there, because that is on par with the actual 
behavior: the buffer records merging do not trigger avro deserailization.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to