alexr17 commented on code in PR #13886:
URL: https://github.com/apache/hudi/pull/13886#discussion_r2393584269
##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestLockAuditingCommand.java:
##########
@@ -56,6 +61,76 @@ public class TestLockAuditingCommand extends
CLIFunctionalTestHarness {
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+ /**
+ * Represents a single audit record (JSON line in a .jsonl file)
+ */
+ static class AuditRecord {
Review Comment:
I feel that the code is becoming over-engineered. I want to avoid modifying
the core path too much. I will keep the generic map serialization for now. If
you feel strongly enough that we should standardize on a specific object that's
fine, but I want to be very flexible, in case we want to write more data later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
