yihua commented on code in PR #14013:
URL: https://github.com/apache/hudi/pull/14013#discussion_r2389634562
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/LSMTimeline.java:
##########
@@ -169,15 +168,17 @@ public static int
latestSnapshotVersion(HoodieTableMetaClient metaClient, Storag
* Returns all the valid snapshot versions.
*/
public static List<Integer> allSnapshotVersions(HoodieTableMetaClient
metaClient, StoragePath archivePath) throws IOException {
- if (!metaClient.getStorage().exists(archivePath)) {
Review Comment:
I think, as the long-term solution, it makes sense to remove the `exists`
API to avoid such exists calls and follow the pattern of a try-catch approach
for FS call efficiency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
