the-other-tim-brown commented on code in PR #13952:
URL: https://github.com/apache/hudi/pull/13952#discussion_r2370846501
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCreateRecordUtils.scala:
##########
@@ -130,9 +131,12 @@ object HoodieCreateRecordUtils {
DataSourceWriteOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.key(),
DataSourceWriteOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.defaultValue()).toBoolean
val requiresPayload = isChangingRecords(operation) &&
!config.isFileGroupReaderBasedMergeHandle
+ val mergeProps = ConfigUtils.getMergeProps(config.getProps,
args.tableConfig.getProps)
+ val deleteContext = new DeleteContext(mergeProps,
writerSchema).withReaderSchema(writerSchema);
// handle dropping partition columns
it.map { avroRec =>
+ val isDelete: Boolean =
AvroRecordContext.getFieldAccessorInstance.isDeleteRecord(avroRec,
deleteContext)
Review Comment:
This is to avoid actually deserializing the message downstream when we do
the event time merging so we can keep the avro data in its bytes form until we
need to inspect the fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
