vamshikrishnakyatham commented on code in PR #14115:
URL: https://github.com/apache/hudi/pull/14115#discussion_r2446062994
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieBaseParquetWriter.java:
##########
@@ -146,8 +147,25 @@ public long getDataSize() {
}
public void write(R object) throws IOException {
- this.parquetWriter.write(object);
- writtenRecordCount.incrementAndGet();
+ try {
+ this.parquetWriter.write(object);
+ writtenRecordCount.incrementAndGet();
+ } catch (RuntimeException e) {
+ String errorMessage = e.getMessage() != null ? e.getMessage() : "";
+ if (isRequiredFieldNullError(errorMessage) &&
errorMessage.contains("_hoodie_is_deleted")) {
Review Comment:
It is thrown by Apache Parquet library. It does not provide custom exception
types like `ParquetValidationException` or `RequiredFieldNullException`. It
only throws generic
`RuntimeException` and we kind of need string parsing to log proper error
message in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
