nsivabalan commented on code in PR #14089:
URL: https://github.com/apache/hudi/pull/14089#discussion_r2452168116
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaCompatibility.java:
##########
@@ -522,15 +523,46 @@ private SchemaCompatibilityResult
checkReaderEnumContainsAllWriterEnumSymbols(fi
private SchemaCompatibilityResult checkFixedSize(final Schema reader,
final Schema writer,
final Deque<LocationInfo>
locations) {
- SchemaCompatibilityResult result =
SchemaCompatibilityResult.compatible();
int actual = reader.getFixedSize();
int expected = writer.getFixedSize();
if (actual != expected) {
String message = String.format("Fixed size field '%s' expected: %d,
found: %d", getLocationName(locations, reader.getType()), expected, actual);
- result =
SchemaCompatibilityResult.incompatible(SchemaIncompatibilityType.FIXED_SIZE_MISMATCH,
reader, writer,
+ return
SchemaCompatibilityResult.incompatible(SchemaIncompatibilityType.FIXED_SIZE_MISMATCH,
reader, writer,
Review Comment:
I cross referenced documentation from deltalake and it aligns
https://delta-docs-incubator.netlify.app/delta-type-widening/
I am not sure where did Jon took inspiration from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
