vamshikrishnakyatham commented on code in PR #14138:
URL: https://github.com/apache/hudi/pull/14138#discussion_r2456671983
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1112,9 +1112,14 @@ public void dropIndex(List<String> metadataPartitions) {
HoodieTableMetaClient metaClient = table.getMetaClient();
// For secondary index and expression index with wrong parameters, index
definition for the MDT partition is
// removed so that such indices are not recreated while initializing the
writer.
+ // Also remove index definitions for col stats and partition stats when
they are dropped (e.g., during downgrade).
metadataPartitions.forEach(partition -> {
- if (MetadataPartitionType.isExpressionOrSecondaryIndex(partition)) {
- metaClient.deleteIndexDefinition(partition);
+ if (MetadataPartitionType.isExpressionOrSecondaryIndex(partition)
+ ||
partition.equals(MetadataPartitionType.COLUMN_STATS.getPartitionPath())
+ ||
partition.equals(MetadataPartitionType.PARTITION_STATS.getPartitionPath())) {
Review Comment:
right, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
