yihua commented on code in PR #14076:
URL: https://github.com/apache/hudi/pull/14076#discussion_r2476412176
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -826,9 +908,7 @@ public void testBackwardsCompatibility(HoodieTableVersion
version) throws Except
}
private void logicalAssertions(Schema tableSchema, String tableBasePath,
Map<String, String> hudiOpts, int tableVersion) {
- if (tableVersion > 8) {
- assertEquals("timestamp-millis",
tableSchema.getField("ts_millis").schema().getLogicalType().getName());
- }
+ assertEquals("timestamp-millis",
tableSchema.getField("ts_millis").schema().getLogicalType().getName());
Review Comment:
Timestamp-millis should be tested regardless of table versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
