yihua commented on code in PR #12494:
URL: https://github.com/apache/hudi/pull/12494#discussion_r2495890937
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/RecordLevelIndexTestBase.scala:
##########
@@ -32,15 +33,13 @@ import org.apache.hudi.metadata.{HoodieBackedTableMetadata,
HoodieTableMetadataU
import org.apache.hudi.storage.StoragePath
import org.apache.hudi.testutils.HoodieSparkClientTestBase
import org.apache.hudi.util.JavaConversions
-
import org.apache.spark.sql._
import org.apache.spark.sql.functions.{col, not}
import org.junit.jupiter.api.Assertions.{assertEquals, assertFalse, assertTrue}
import org.junit.jupiter.api._
import java.util.concurrent.atomic.AtomicInteger
import java.util.stream.Collectors
-
Review Comment:
Keep the import grouping?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestSecondaryIndex.scala:
##########
@@ -31,13 +32,11 @@ import
org.apache.hudi.metadata.HoodieMetadataPayload.SECONDARY_INDEX_RECORD_KEY
import org.apache.hudi.metadata.SecondaryIndexKeyUtils
import org.apache.hudi.storage.StoragePath
import org.apache.hudi.{DataSourceReadOptions, DataSourceWriteOptions}
-
import org.apache.spark.sql.SaveMode
import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase
import org.junit.jupiter.api.Assertions.{assertEquals, assertFalse, assertTrue}
import java.util.concurrent.atomic.AtomicInteger
-
Review Comment:
Keep the import grouping?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -329,7 +329,7 @@ private MetadataValues
populateMetadataFields(HoodieRecord<T> hoodieRecord) {
if (config.populateMetaFields()) {
String seqId =
HoodieRecord.generateSequenceId(instantTime, getPartitionId(),
RECORD_COUNTER.getAndIncrement());
- metadataValues.setFileName(fileId);
+ metadataValues.setFileName(writer.getLogFile().getFileName());
Review Comment:
This is a breaking change on the storage format where the
`_hoodie_file_name` stores the file name instead of the file ID in log files.
Blocking the PR from merging until we have an alignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
