rahil-c commented on code in PR #14313:
URL: https://github.com/apache/hudi/pull/14313#discussion_r2550952471
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/LSMTimelineWriter.java:
##########
@@ -302,10 +303,12 @@ public void compactFiles(List<String> candidateFiles,
String compactedFileName)
.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO)
.getFileReader(config, new StoragePath(archivePath, fileName))) {
// Read the meta entry
- try (ClosableIterator<IndexedRecord> iterator =
reader.getIndexedRecordIterator(HoodieLSMTimelineInstant.getClassSchema(),
HoodieLSMTimelineInstant.getClassSchema())) {
+ //TODO boundary to revisit in later pr to use HoodieSchema directly
+ try (ClosableIterator<IndexedRecord> iterator =
reader.getIndexedRecordIterator(HoodieSchema.fromAvroSchema(HoodieLSMTimelineInstant.getClassSchema()),
Review Comment:
need to fix this to use variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
