zhedoubushishi commented on a change in pull request #2328:
URL: https://github.com/apache/hudi/pull/2328#discussion_r548340732
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -130,9 +130,6 @@ private[hudi] object HoodieSparkSqlWriter {
// scalastyle:off
if (parameters(ENABLE_ROW_WRITER_OPT_KEY).toBoolean &&
operation == WriteOperationType.BULK_INSERT) {
- if (!SPARK_VERSION.startsWith("2.")) {
Review comment:
Yea I think this depends on whether Spark 4 will change the datasource
API api again, if it keeps the same datasource v2 api, then even for Spark 4 we
can still use our exist code, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
