linliu-code commented on code in PR #14261:
URL: https://github.com/apache/hudi/pull/14261#discussion_r2557186345
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -218,6 +219,34 @@ record -> {
});
}
+ @Override
+ public void loadCompactionDetailsInMemory(int limit) {
+ loadInstantsWithLimit(limit, true,
+ record -> {
+ Object action = record.get(ACTION_STATE);
+ return
record.get(ACTION_TYPE_KEY).toString().equals(HoodieTimeline.COMPACTION_ACTION)
+ && (action == null ||
org.apache.hudi.common.table.timeline.HoodieInstant.State.INFLIGHT.toString().equals(action.toString()));
+ });
+ }
+
+ @Override
+ public void loadCompletedInstantDetailsInMemory(String startTs, String
endTs) {
+ loadInstants(new ClosedClosedTimeRangeFilter(startTs, endTs), null, true,
+ record -> {
+ Object action = record.get(ACTION_STATE);
+ return action == null ||
org.apache.hudi.common.table.timeline.HoodieInstant.State.COMPLETED.toString().equals(action.toString());
+ });
+ }
+
+ @Override
+ public void loadCompletedInstantDetailsInMemory(int limit) {
+ loadInstantsWithLimit(limit, true,
+ record -> {
+ Object action = record.get(ACTION_STATE);
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
