yihua commented on code in PR #14060:
URL: https://github.com/apache/hudi/pull/14060#discussion_r2558283822
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -1225,6 +1174,7 @@ class TestCOWDataSource extends HoodieSparkClientTestBase
with ScalaAssertionSup
}
}
+ // TODO: Should this be deleted?
Review Comment:
The test should be kept as it does not use glob pattern.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -1452,7 +1402,7 @@ class TestCOWDataSource extends HoodieSparkClientTestBase
with ScalaAssertionSup
partitionEncode: Boolean,
isMetadataEnabled: Boolean,
recordType: HoodieRecordType): Unit = {
- val (writeOpts, readOpts) = getWriterReaderOpts(recordType,
enableFileIndex = enableFileIndex)
+ val (writeOpts, readOpts) = getWriterReaderOpts(recordType)
Review Comment:
The first argument `enableFileIndex` can be removed.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -1225,6 +1174,7 @@ class TestCOWDataSource extends HoodieSparkClientTestBase
with ScalaAssertionSup
}
}
+ // TODO: Should this be deleted?
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
