vamsikarnika commented on code in PR #14260:
URL: https://github.com/apache/hudi/pull/14260#discussion_r2558566052
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieBaseFile.java:
##########
@@ -115,16 +119,19 @@ private static String[] handleHudiGeneratedFile(String
fileName) {
}
// case where there is no '.' in file name (no file suffix like .parquet)
values[1] = fileName.substring(lastUnderscoreIndex + 1);
+ values[2] = fileName;
return values;
}
private static String[] handleExternallyGeneratedFile(String fileName) {
- String[] values = new String[2];
+ String[] values = new String[3];
// file name has format <originalFileName>_<commitTime>_hudiext and
originalFileName is used as fileId
int lastUnderscore = fileName.lastIndexOf(UNDERSCORE);
int secondToLastUnderscore = fileName.lastIndexOf(UNDERSCORE,
lastUnderscore - 1);
- values[0] = fileName.substring(0, secondToLastUnderscore);
+ int firstUnderscore = fileName.indexOf(UNDERSCORE);
+ values[0] = fileName.substring(0, firstUnderscore);
Review Comment:
Added a check for UV so that only uv files takes this code path
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieBaseFile.java:
##########
@@ -115,16 +119,19 @@ private static String[] handleHudiGeneratedFile(String
fileName) {
}
// case where there is no '.' in file name (no file suffix like .parquet)
values[1] = fileName.substring(lastUnderscoreIndex + 1);
+ values[2] = fileName;
return values;
}
private static String[] handleExternallyGeneratedFile(String fileName) {
- String[] values = new String[2];
+ String[] values = new String[3];
// file name has format <originalFileName>_<commitTime>_hudiext and
originalFileName is used as fileId
int lastUnderscore = fileName.lastIndexOf(UNDERSCORE);
int secondToLastUnderscore = fileName.lastIndexOf(UNDERSCORE,
lastUnderscore - 1);
- values[0] = fileName.substring(0, secondToLastUnderscore);
+ int firstUnderscore = fileName.indexOf(UNDERSCORE);
+ values[0] = fileName.substring(0, firstUnderscore);
Review Comment:
Add docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
