danny0405 commented on a change in pull request #2371:
URL: https://github.com/apache/hudi/pull/2371#discussion_r548495245
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##########
@@ -236,7 +236,7 @@ public static HoodieDefaultTimeline
filterInstantsTimeline(HoodieDefaultTimeline
return false;
})
.collect(Collectors.joining(","));
- return Option.of(incrementalInputPaths);
+ return StringUtils.isNullOrEmpty(incrementalInputPaths) ? Option.empty():
Option.of(incrementalInputPaths);
}
Review comment:
Looks fine, can we have some test case there ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
