danny0405 commented on a change in pull request #2366:
URL: https://github.com/apache/hudi/pull/2366#discussion_r548518424
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java
##########
@@ -63,13 +69,25 @@
// TODO(vc): Should we handle also non-hoodie splits here?
Map<Path, HoodieTableMetaClient> partitionsToMetaClient =
getTableMetaClientByBasePath(conf, partitionsToParquetSplits.keySet());
+ boolean useFileListingFromMetadata = conf.getBoolean(METADATA_ENABLE_PROP,
DEFAULT_METADATA_ENABLE_FOR_READERS);
+ boolean verifyFileListing = conf.getBoolean(METADATA_VALIDATE_PROP,
DEFAULT_METADATA_VALIDATE);
Review comment:
These 2 config options is every where, can we just pass the `JobConf` to
the tool method `FileSystemViewManager.createInMemoryFileSystemView` and fetch
them inside the method ? That would make the invocation more clean, IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
