nsivabalan commented on code in PR #14260:
URL: https://github.com/apache/hudi/pull/14260#discussion_r2560403147
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -179,33 +191,36 @@ protected List<HoodieFileGroup>
buildFileGroups(FileStatus[] statuses, HoodieTim
protected List<HoodieFileGroup> buildFileGroups(Stream<HoodieBaseFile>
baseFileStream,
Stream<HoodieLogFile>
logFileStream, HoodieTimeline timeline, boolean addPendingCompactionFileSlice) {
- Map<Pair<String, String>, List<HoodieBaseFile>> baseFiles =
+ Map<Triple<String, String, Option<String>>, List<HoodieBaseFile>>
baseFiles =
Review Comment:
only dilemma I have on these code changes is maintainability. wondering if
somehow we can detect the caller for unified view vs not, I prefer to keep the
changes separate. for eg, `if else` block and not have embedded changes.
We should introduce any bugs for non unified view at any cost. Just relying
on CI succeeding may not qualify as good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
