the-other-tim-brown commented on code in PR #14344:
URL: https://github.com/apache/hudi/pull/14344#discussion_r2561096870
##########
hudi-sync/hudi-datahub-sync/src/main/java/org/apache/hudi/sync/datahub/DataHubSyncTool.java:
##########
@@ -83,20 +83,20 @@ public void syncHoodieTable() {
}
}
- private void syncSchema() throws Exception {
Review Comment:
Throwing a general `Exception` is a code-smell. You want to throw checked
exceptions so the caller can decide how to handle them.
##########
hudi-sync/hudi-adb-sync/src/main/java/org/apache/hudi/sync/adb/HoodieAdbJdbcClient.java:
##########
@@ -105,9 +105,9 @@ private void createAdbConnection() {
}
@Override
- public void createTable(String tableName, MessageType storageSchema, String
inputFormatClass,
- String outputFormatClass, String serdeClass,
- Map<String, String> serdeProperties, Map<String, String>
tableProperties) {
+ public void createTable(String tableName, HoodieSchema storageSchema, String
inputFormatClass,
+ String outputFormatClass, String serdeClass,
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
