voonhous commented on code in PR #14311:
URL: https://github.com/apache/hudi/pull/14311#discussion_r2563984587
##########
hudi-common/src/main/java/org/apache/hudi/stats/ValueType.java:
##########
@@ -244,77 +246,90 @@ public static ValueType
fromParquetPrimitiveType(PrimitiveType primitiveType) {
}
}
- public static ValueType fromSchema(Schema schema) {
- switch (schema.getType()) {
+ /**
+ * Infers ValueType from HoodieSchema for type inference in column
statistics.
+ * This method uses HoodieSchema for in-memory processing while maintaining
+ * compatibility with existing Avro-based serialization.
+ *
+ * @param schema the HoodieSchema to infer type from
+ * @return the corresponding ValueType
+ * @throws IllegalArgumentException if the schema type is not supported
+ * @since 1.2.0
+ */
+ public static ValueType fromSchema(HoodieSchema schema) {
Review Comment:
Modified `fromSchema` to not rely on **avro** for conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
