TheR1sing3un commented on code in PR #14366:
URL: https://github.com/apache/hudi/pull/14366#discussion_r2565641832
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java:
##########
@@ -68,19 +69,156 @@ enum LoadMode {
}
/**
- * A time based filter with range (startTs, endTs].
+ * A time based filter with range, there may be different forms of interval
types.
+ * <li>Double open <code>(startTs, endTs)</code></li>
+ * <li>Left closed right open <code>[startTs, endTs)</code></li>
+ * <li>Left open right closed <code>(startTs, endTs]</code></li>
+ * <li>Double closed <code>[startTs, endTs]</code></li>
+ * <li>StartTs only <code>[startTs, +∞)</code></li>
+ * <li>EndTs only <code>(-∞, endTs]</code></li>
*/
class TimeRangeFilter {
Review Comment:
I refactored this class because the previous implementation was difficult to
implement method `boolean intersects(filter)`, and I also refactored and
optimized the use of some methods and code structure to enhance the robustness
and maintainability of the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
