yihua commented on code in PR #14354:
URL: https://github.com/apache/hudi/pull/14354#discussion_r2569949576
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -453,7 +469,13 @@ protected void ensurePartitionLoadedCorrectly(String
partition) {
if (!isPartitionAvailableInStore(partitionPathStr)) {
// Not loaded yet
try {
- LOG.info("Building file system view for partition ({})",
partitionPathStr);
+ // For metadata table, always log at DEBUG. For data table, log at
INFO once every 10 times
+ if (metaClient.isMetadataTable()) {
+ LOG.debug("Building file system view for partition ({})",
partitionPathStr);
+ } else {
+ partitionViewBuildSamplingLogger.logInfoOrDebug(
+ "Building file system view for partition ({})",
partitionPathStr);
+ }
Review Comment:
What's the point of doing log sampling here? In this case, log entries for
a subset of partitions will be missing, which can be more confusing, leading to
users thinking that some partitions are not scanned. Would it be better to
simply make this DEBUG level?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -390,7 +400,13 @@ private void ensurePartitionsLoadedCorrectly(List<String>
partitionList) {
long beginTs = System.currentTimeMillis();
// Not loaded yet
try {
- LOG.debug("Building file system view for partitions: {}",
partitionSet);
+ // For metadata table, always log at DEBUG. For data table, log at
INFO once every 10 times
+ if (metaClient.isMetadataTable()) {
+ LOG.debug("Building file system view for partitions: {}",
partitionSet);
+ } else {
+ partitionViewBuildSamplingLogger.logInfoOrDebug(
+ "Building file system view for partitions: {}", partitionSet);
+ }
Review Comment:
What's the motivation of showing the partition set here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
