Karl-WangSK commented on a change in pull request #2260:
URL: https://github.com/apache/hudi/pull/2260#discussion_r548886752
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java
##########
@@ -65,10 +66,12 @@ protected HoodieCompactionPlan scheduleCompaction() {
int deltaCommitsSinceLastCompaction =
table.getActiveTimeline().getDeltaCommitTimeline()
.findInstantsAfter(lastCompactionTs,
Integer.MAX_VALUE).countInstants();
- if (config.getInlineCompactDeltaCommitMax() >
deltaCommitsSinceLastCompaction) {
+ if (config.getInlineCompactDeltaCommitMax() >
deltaCommitsSinceLastCompaction
+ && timeCompaction(instantTime, initialTime,
deltaCommitsSinceLastCompaction)) {
Review comment:
yes. So two conditions in `if` means they won't trigger compact.
Return true means imcompactable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
