hudi-bot opened a new issue, #15412:
URL: https://github.com/apache/hudi/issues/15412

   In 
[Metrics.java|https://github.com/apache/hudi/blob/f5de4e434b33720d4846c6fe2450539a284ea14f/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java#L63-L65]
 we are calling the close method on a class instead of the Reporter's `stop` 
method. The `stop` method according to the Java docs "Should be used to stop 
channels, streams and release resources." 
   
   For most reporters these two actions are equivalent but the 
[JmxReportServer|https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/JmxReporterServer.java#L127]
 has a more involved stop method that must be called. 
   
    
   
   Relates to discussion 
[here|https://github.com/apache/hudi/issues/5249#issuecomment-1235020970]
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-4796
   - Type: Bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to