hudi-bot opened a new issue, #15883:
URL: https://github.com/apache/hudi/issues/15883

   Now ,Use listingBasedRollbackStrategy may omit invalid files when 
commitMetadata is not completed.The reason for this problem is due to use 
instantToRollback timestamp and the baseCommitTime of the logFile to judge 
whether the Logfiles is valid.
   
   {code:java}
   // commit is instant time which should be rollback
   // in most cases  BaseCommitTime  may not equals commit
   (path) -> {
         if (path.toString().endsWith(basefileExtension)) {
           String fileCommitTime = FSUtils.getCommitTime(path.getName());
           return commit.equals(fileCommitTime);
         } else if (FSUtils.isLogFile(path)) {
           // Since the baseCommitTime is the only commit for new log files, 
it's okay here
           String fileCommitTime = FSUtils.getBaseCommitTimeFromLogPath(path);
           return commit.equals(fileCommitTime);
         }
         return false;
       };
   {code}
   
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-6029
   - Type: Bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to