hudi-bot opened a new issue, #15929:
URL: https://github.com/apache/hudi/issues/15929

   org.apache.hudi.common.testutils.HoodieTestDataGenerator has been omitting 
ordering value when creating RawTripTestPayload, as a result, the records 
generated are not usable for merging. This involves these 2 constructors
   
   
   {code:java}
   
org.apache.hudi.common.testutils.RawTripTestPayload#RawTripTestPayload(org.apache.hudi.common.util.Option<java.lang.String>,
 java.lang.String, java.lang.String, java.lang.String, java.lang.Boolean, 
java.lang.Comparable)
   
org.apache.hudi.common.testutils.RawTripTestPayload#RawTripTestPayload(java.lang.String,
 java.lang.String, java.lang.String, java.lang.String)
   {code}
   
   
   On the other hand, there are test cases construct RawTripTestPayload with 
json data directly and fix the partition field as `time` using this constructor
   
   {code:java}
   
org.apache.hudi.common.testutils.RawTripTestPayload#RawTripTestPayload(java.lang.String)
   {code}
   
   These are contradicting usage of this class. We should create another 
payload class for the 2nd use case (fixed simple schema). And make 
RawTripTestPayload support setting ordering value with HoodieTestDataGenerator.
   
   
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-6164
   - Type: Improvement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to