xushiyan commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r549528498
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/FileCreateUtils.java
##########
@@ -83,6 +83,17 @@ private static void createMetaFile(String basePath, String
instantTime, String s
}
}
+ private static void createMetaFile(FileSystem fs, String basePath, String
instantTime, String suffix) throws IOException {
Review comment:
Looks like this new set of helpers is a version that uses hadoop fs
instead of java nio. Would it align better if we put `FileSystem fs` as the
last argument? so that other args match with the java nio version. This applies
to the few new helper methods below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
