hudi-bot opened a new issue, #17440: URL: https://github.com/apache/hudi/issues/17440
[https://github.com/apache/hudi/pull/13519#discussion_r2263549244] During upgrade/downgrade, there are two sets of configurations: toUpdate and toRemove. There could be some corners that a property is update/added, and then removed later, but may be added again. If we don't anything, we could see that the configuration will exist in both toUpdate and toRemove config sets. Therefore, we need to make this logic straight. Ethan's comment: {code:java} If the table is upgraded from 6 to 9, when executing the eight-to-nine upgrade handler, based on the logic the table config fetched here is still from original version 6, because the table config is only rewritten after all upgrade is called. Does the logic here assume that some table configs are already updated to table version 8? I think this assumption make senses for maintaining the upgrade logic, but it requires changing the logic to follow that, i.e., passing in the updated and deleted configs from 6->8 upgrades. {code} ## JIRA info - Link: https://issues.apache.org/jira/browse/HUDI-9702 - Type: Sub-task - Parent: https://issues.apache.org/jira/browse/HUDI-9560 - Fix version(s): - 1.1.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
