rahil-c commented on code in PR #14355:
URL: https://github.com/apache/hudi/pull/14355#discussion_r2579025705
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -644,10 +647,11 @@ private boolean isPartitioned() {
}
@VisibleForTesting
- public Schema getTableAvroSchema() {
+ public HoodieSchema getTableHoodieSchema() {
try {
TableSchemaResolver schemaResolver = new TableSchemaResolver(metaClient);
- return schemaResolver.getTableAvroSchema();
+ Schema avroSchema = schemaResolver.getTableAvroSchema();
+ return HoodieSchema.fromAvroSchema(avroSchema);
Review Comment:
@the-other-tim-brown Wondering if you can help me better understand the ask,
is it just for `schemaResolver` to have some helper called `getTableSchema`
which basically just delegates to `getTableAvroSchema` but then wraps it around
the `HoodieSchema.fromAvroSchema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
