the-other-tim-brown commented on code in PR #14311:
URL: https://github.com/apache/hudi/pull/14311#discussion_r2581752593
##########
hudi-common/src/test/java/org/apache/hudi/metadata/TestHoodieTableMetadataUtil.java:
##########
@@ -281,37 +283,27 @@ void testFilterNestedLogicalTimestampColumn() {
@Test
void testIsTimestampMillisField() {
// Test timestamp-millis
- Schema timestampMillisSchema = Schema.create(Schema.Type.LONG);
- LogicalTypes.timestampMillis().addToSchema(timestampMillisSchema);
+ HoodieSchema timestampMillisSchema = HoodieSchema.createTimestampMillis();
assertTrue(HoodieTableMetadataUtil.isTimestampMillisField(timestampMillisSchema),
"Should return true for timestamp-millis");
- // Test local-timestamp-millis
- Schema localTimestampMillisSchema = Schema.create(Schema.Type.LONG);
-
LogicalTypes.localTimestampMillis().addToSchema(localTimestampMillisSchema);
-
assertTrue(HoodieTableMetadataUtil.isTimestampMillisField(localTimestampMillisSchema),
- "Should return true for local-timestamp-millis");
Review Comment:
We do have local timestamp and we support millis and micros for timestamps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
