voonhous commented on code in PR #14311:
URL: https://github.com/apache/hudi/pull/14311#discussion_r2582166860
##########
hudi-common/src/test/java/org/apache/hudi/common/schema/TestHoodieSchemaUtils.java:
##########
@@ -301,4 +304,264 @@ public void testConsistencyWithAvroUtilities() {
// Should produce equivalent schemas
assertEquals(avroResult.toString(), hoodieResult.toString());
}
+
+ @Test
+ public void testGetNestedFieldTopLevel() {
+ // Create simple schema
+ HoodieSchema schema = HoodieSchema.createRecord(
+ "TestRecord",
+ null,
+ null,
+ Arrays.asList(
+ HoodieSchemaField.of("id",
HoodieSchema.create(HoodieSchemaType.STRING)),
+ HoodieSchemaField.of("name",
HoodieSchema.create(HoodieSchemaType.STRING))
+ )
+ );
+
+ // Test getting top-level field
+ Pair<String, HoodieSchemaField> result =
HoodieSchemaUtils.getNestedField(schema, "id");
+
+ assertNotNull(result);
+ assertEquals("id", result.getLeft());
+ assertEquals("id", result.getRight().name());
+ assertEquals(HoodieSchemaType.STRING,
result.getRight().schema().getType());
+ }
+
+ @Test
+ public void testGetNestedFieldSingleLevel() {
+ // Create schema with nested record
+ HoodieSchema addressSchema = HoodieSchema.createRecord(
+ "Address",
+ null,
+ null,
+ Arrays.asList(
+ HoodieSchemaField.of("street",
HoodieSchema.create(HoodieSchemaType.STRING)),
+ HoodieSchemaField.of("city",
HoodieSchema.create(HoodieSchemaType.STRING))
+ )
+ );
+
+ HoodieSchema schema = HoodieSchema.createRecord(
+ "Person",
+ null,
+ null,
+ Arrays.asList(
+ HoodieSchemaField.of("name",
HoodieSchema.create(HoodieSchemaType.STRING)),
+ HoodieSchemaField.of("address", addressSchema)
+ )
+ );
+
+ // Test getting nested field
+ Pair<String, HoodieSchemaField> result =
HoodieSchemaUtils.getNestedField(schema, "address.city");
+
+ assertNotNull(result);
+ assertEquals("address.city", result.getLeft());
+ assertEquals("city", result.getRight().name());
+ assertEquals(HoodieSchemaType.STRING,
result.getRight().schema().getType());
+ }
+
+ @Test
+ public void testGetNestedFieldMultiLevel() {
+ // Create 3-level nested schema
+ HoodieSchema profileSchema = HoodieSchema.createRecord(
+ "Profile",
+ null,
+ null,
+ Arrays.asList(
+ HoodieSchemaField.of("bio",
HoodieSchema.create(HoodieSchemaType.STRING)),
+ HoodieSchemaField.of("ts_millis",
HoodieSchema.createTimestampMillis())
+ )
+ );
+
+ HoodieSchema userSchema = HoodieSchema.createRecord(
+ "User",
+ null,
+ null,
+ Arrays.asList(
+ HoodieSchemaField.of("profile", profileSchema),
+ HoodieSchemaField.of("age",
HoodieSchema.create(HoodieSchemaType.INT))
+ )
+ );
+
+ HoodieSchema rootSchema = HoodieSchema.createRecord(
+ "Root",
+ null,
+ null,
+ Arrays.asList(
+ HoodieSchemaField.of("user", userSchema),
+ HoodieSchemaField.of("event_id",
HoodieSchema.create(HoodieSchemaType.STRING))
+ )
+ );
+
+ // Test getting deeply nested field
+ Pair<String, HoodieSchemaField> result =
HoodieSchemaUtils.getNestedField(rootSchema, "user.profile.ts_millis");
+
+ assertNotNull(result);
+ assertEquals("user.profile.ts_millis", result.getLeft());
+ assertEquals("ts_millis", result.getRight().name());
+ assertEquals(HoodieSchemaType.TIMESTAMP,
result.getRight().schema().getType());
+ }
+
+ @Test
+ public void testGetNestedFieldWithTimestampTypes() {
+ // Create schema with different timestamp types
+ HoodieSchema schema = HoodieSchema.createRecord(
+ "TimestampRecord",
+ null,
+ null,
+ Arrays.asList(
+ HoodieSchemaField.of("ts_millis",
HoodieSchema.createTimestampMillis()),
+ HoodieSchemaField.of("ts_micros",
HoodieSchema.createTimestampMicros()),
+ HoodieSchemaField.of("date_field", HoodieSchema.createDate())
+ )
+ );
+
+ // Test timestamp-millis field
+ Pair<String, HoodieSchemaField> millisResult =
HoodieSchemaUtils.getNestedField(schema, "ts_millis");
+ assertNotNull(millisResult);
+ assertEquals("ts_millis", millisResult.getRight().name());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
