the-other-tim-brown commented on code in PR #17450: URL: https://github.com/apache/hudi/pull/17450#discussion_r2583522997
########## hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestParquetToSparkSchemaUtils.java: ########## @@ -18,8 +18,14 @@ package org.apache.hudi.hive; +import org.apache.hudi.avro.AvroSchemaUtils; Review Comment: The unit under test is the `ParquetToSparkSchemaUtils` method which takes in a `MessageType`. Not an Avro. The test uses Avro to generate the sample MessageType. This matches the runtime of the system which will request an avro schema, convert it to MessageType, and then call ParquetToSparkSchemaUtils. The converter class (and then the test class to follow conventions) will be changed in https://github.com/apache/hudi/pull/14344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
